Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: setup HUBBLE_SERVER for the Hubble CLI Deployment #24154

Merged
merged 1 commit into from Mar 7, 2023
Merged

examples: setup HUBBLE_SERVER for the Hubble CLI Deployment #24154

merged 1 commit into from Mar 7, 2023

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Mar 3, 2023

Before this patch, the Hubble CLI Deployment example would use the CLI's default HUBBLE_SERVER (i.e. localhost:4245) which doesn't work in a kubernetes context.

This patch set HUBBLE_SERVER based on the HUBBLE_RELAY_SERVICE env variables, to make hubble observe work out-of-the-box.

@kaworu
examples: setup HUBBLE_SERVER for the Hubble CLI Deployment
3b936c7 
Before this patch, the Hubble CLI Deployment example would use the CLI's
default HUBBLE_SERVER (i.e. localhost:4245) which doesn't work in a
kubernetes context.

This patch set HUBBLE_SERVER based on the HUBBLE_RELAY_SERVICE env
variables, to make `hubble observe` work out-of-the-box.

Signed-off-by: Alexandre Perrin <alex@isovalent.com>
@kaworu kaworu added kind/enhancement This would improve or streamline existing functionality. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. sig/hubble Impacts hubble server or relay labels Mar 3, 2023
@kaworu kaworu added this to the 1.14 milestone Mar 3, 2023
@kaworu kaworu requested a review from a team as a code owner March 3, 2023 10:44
@kaworu kaworu requested a review from chancez March 3, 2023 10:44
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 3, 2023
@kaworu kaworu added the release-note/misc This PR makes changes that have no direct user impact. label Mar 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 3, 2023
@kaworu
Copy link
Member Author

kaworu commented Mar 3, 2023

ConformanceGatewayAPI CI hit #23999

@kaworu
Copy link
Member Author

kaworu commented Mar 6, 2023

No CI test covering this file, so marking as ready-to-merge.

@kaworu kaworu added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 6, 2023
@YutaroHayakawa YutaroHayakawa merged commit 95a680a into cilium:master Mar 7, 2023
@kaworu kaworu deleted the pr/kaworu/examples/setup-HUBBLE_SERVER-for-hubble-cli branch March 7, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancez chancez chancez approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaworu @chancez @YutaroHayakawa