-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: #24185 Cilium-operator crash on empty azure node pools #24189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 6, 2023
github-actions
bot
added
the
kind/community-contribution
This was a contribution made by a community member.
label
Mar 6, 2023
I've tested it manually on azure cluster with k8s 1.24.9 |
aanm
added
the
release-note/bug
This PR fixes an issue in a previous release of Cilium.
label
Mar 6, 2023
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 6, 2023
aanm
added
needs-backport/1.12
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
labels
Mar 6, 2023
@tommyp1ckles Any ETA for the review of this? |
@forgems sorry for the delay - I'll take a look. |
tommyp1ckles
approved these changes
Mar 14, 2023
Commit 7819909d33dd15686a6924d496f60bdc1253feac does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
The author needs to add signoff to their commits before merge.
label
Mar 14, 2023
christarazi
removed request for
nathanjsweet,
tklauser,
brlbil,
aspsk,
ldelossa,
sayboras,
rgo3 and
qmonnet
March 14, 2023 21:02
christarazi
added
area/operator
Impacts the cilium-operator component
area/azure
Impacts Azure based IPAM.
labels
Mar 14, 2023
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Mar 15, 2023
9 tasks
29 tasks
NikAleksandrov
added
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
and removed
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
labels
Mar 23, 2023
youngnick
added
backport-done/1.12
The backport for Cilium 1.12.x for this PR is done.
and removed
backport-pending/1.12
labels
Mar 23, 2023
jibi
added
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
and removed
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
labels
Apr 7, 2023
michi-covalent
moved this from Needs backport from master
to Backport done to v1.12
in 1.12.9
Apr 14, 2023
gentoo-root
moved this from Needs backport from master
to Backport done to v1.13
in 1.13.2
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/azure
Impacts Azure based IPAM.
area/operator
Impacts the cilium-operator component
backport-done/1.12
The backport for Cilium 1.12.x for this PR is done.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
kind/community-contribution
This was a contribution made by a community member.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty VirtualMachineScaleSets returns 404 on ListVirtualMachineScaleSetNetworkInterfaces if there are no nodes in it. Continue with next VirtualMachineScaleSet in that case.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Azure allows for empty user node pools. In that case ListVirtualMachineScaleSetNetworkInterfaces will return 404 when trying to get interfaces associated with given node pool. With this change it will continue with next VirtualMachineScaleSet if this is NotFound error.
Fixes: #24185