docs: Update egress gateway limitations #24244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mention that the egress gateway is for IPv4 traffic, but we never explictly say that IPv6 isn't supported. This is apparently not obvious to everyone so let's state it here. This commit moves the feature incompatibilies subsection under the Preliminary Considerations section. Another subsection will be added there by the next commit. Signed-off-by: Paul Chaignon <paul@cilium.io>
This delay can have a security impact if the egress gateway masquerading is used to enforce policies in appliances outside the cluster. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
area/documentation
qmonnet
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
First commit description says:
This commit moves the feature incompatibilies subsection under the
Preliminary Considerations section.
It renames the section, but doesn't appear to move it?
Checkpatch caught a typo in the same commit description (explictly).
Other than these, looks all good.
It kind of moves it if you considered the rendered output. The text doesn't move but the incompatibility subsection is now under the Preliminary Considerations section when it used to be its own section. So it's "move under" as in "in the hierarchy" not as in "move below". |
jibi
approved these changes
Mar 9, 2023
pchaigno
added
the
ready-to-merge
29 tasks
NikAleksandrov
added
backport-pending/1.13
jibi
added
backport-done/1.13
gentoo-root
moved this from Needs backport from master
to Backport done to v1.13
in 1.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.