endpoint: correctly log IPv6 addresses #24255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: f3a4c4d#r103598930 Fixes: f3a4c4d ("endpoint: convert Endpoint from addressing.CiliumIPv{4,6} to netip.Addr") Reported-by: Joe Stringer <joe@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
release-note/misc
tklauser
referenced
this pull request
Mar 8, 2023
A netip.Addr always uses 24 bytes, regardless of the address type. An addressing.CiliumIPv4 uses 28 bytes (24 bytes for the slice header and 4 bytes for the address). An addressing.CiliumIPv6 uses 56 bytes (24 bytes for the slice header and 32 bytes for the address). Also see [1] for more details on further advantages of the netip types in terms of performance. [1] https://tailscale.com/blog/netaddr-new-ip-type-for-go/ This change thus slightly reduces the in-memory size of the Endpoint type and also allows to drop the custom addressing types in favor of Go standard library types with corresponding helper functions and methods. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tommyp1ckles
approved these changes
Mar 8, 2023
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
29 tasks
NikAleksandrov
added
backport-pending/1.13
jibi
added
backport-done/1.13
gentoo-root
moved this from Needs backport from master
to Backport done to v1.13
in 1.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: f3a4c4d#r103598930
Fixes: f3a4c4d ("endpoint: convert Endpoint from addressing.CiliumIPv{4,6} to netip.Addr")
Reported-by: Joe Stringer joe@cilium.io