Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: kubeProxyReplacement=strict / kube-proxy co-existence #24407

Merged
merged 1 commit into from
Mar 16, 2023
Merged

doc: kubeProxyReplacement=strict / kube-proxy co-existence #24407

merged 1 commit into from
Mar 16, 2023

Conversation

PhilipSchmid
Copy link
Contributor

Clarified that even though it's highly not recommended to do so, it's still possible to leave Kube-Proxy running and at the same time use KPR mode set to strict.
Motivation: Some users might not be able to uninstall kube-proxy from their Kubernetes distributions (e.g. RKE1).

@PhilipSchmid
doc: kubeProxyReplacement=strict / kube-proxy co-existence
010b147 
Signed-off-by: Philip Schmid <philip.schmid@isovalent.com>
@PhilipSchmid PhilipSchmid requested review from a team as code owners March 16, 2023 08:37
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 16, 2023
borkmann
borkmann approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for helping to improve the docs! lgtm

@borkmann borkmann added the release-note/misc This PR makes changes that have no direct user impact. label Mar 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 16, 2023
@borkmann borkmann added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 16, 2023
@borkmann borkmann added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Mar 16, 2023
aditighag
aditighag approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@aditighag aditighag merged commit 477b43b into cilium:master Mar 16, 2023
@PhilipSchmid PhilipSchmid deleted the pr/philip/update_kpr_kube_proxy_doc branch March 16, 2023 18:37
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 23, 2023
Merged
29 tasks
@NikAleksandrov NikAleksandrov added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 23, 2023
@jibi jibi added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 7, 2023
@gentoo-root gentoo-root mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@aditighag aditighag aditighag approved these changes

@aspsk aspsk Awaiting requested review from aspsk aspsk was automatically assigned from cilium/sig-lb

@qmonnet qmonnet Awaiting requested review from qmonnet qmonnet was automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
cilium v1.13.2
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PhilipSchmid @borkmann @aditighag @jibi @NikAleksandrov