-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gateway-api: Re-queue gateway for namespace change #24624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 29, 2023
sayboras
changed the title
gateway-api: Re-queue gateway for namespace change in allowRoutes
gateway-api: Re-queue gateway for namespace change
Mar 29, 2023
sayboras
added
the
release-note/bug
This PR fixes an issue in a previous release of Cilium.
label
Mar 29, 2023
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 29, 2023
sayboras
added
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
labels
Mar 29, 2023
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 29, 2023
sayboras
force-pushed
the
tam/httproute-cross-ns
branch
2 times, most recently
from
March 29, 2023 11:26
ba2b2e6
to
984f3aa
Compare
mhofstetter
reviewed
Mar 29, 2023
This commit is to make sure that if there is any changes in namespace mentioned in gateway.spec.listener[*].allowRoutes, the reconciliation loop should kick off for Gateway resource. For example, the namespace label can be added to be included or excluded from what mentioned in gateway.spec.listener[*].allowRoutes. Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/httproute-cross-ns
branch
from
April 1, 2023 11:59
984f3aa
to
4e83f5a
Compare
mhofstetter
approved these changes
Apr 3, 2023
Member
Author
/test Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment |
youngnick
approved these changes
Apr 3, 2023
/test-1.24-5.4 |
1 similar comment
/test-1.24-5.4 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Apr 3, 2023
jibi
added
the
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
label
Apr 5, 2023
jibi
added
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
and removed
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
labels
Apr 5, 2023
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.13
in 1.13.2
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit is to make sure that if there is any changes in namespace mentioned in gateway.spec.listener[].allowRoutes, the reconciliation loop should kick off for Gateway resource. For example, the namespace label can be added to be included or excluded from what mentioned in gateway.spec.listener[*].allowRoutes.