Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.12 Backports 2023-04-03 #24709

Merged
merged 3 commits into from
Apr 5, 2023
Merged

v1.12 Backports 2023-04-03 #24709

merged 3 commits into from
Apr 5, 2023

Conversation

jibi
Copy link
Member

@jibi jibi commented Apr 3, 2023

Once this PR is merged, you can update the PR labels via:

for pr in 24575 24484; do contrib/backporting/set-labels.py $pr done 1.12; done

or with

make add-labels BRANCH=v1.12 ISSUES=24575,24484

mhofstetter and others added 3 commits April 3, 2023 15:42
[ upstream commit 772f4a0 ]

Currently, the log field k8sNamespace contains the name of the pod
instead of the actual namespace when an endpoint gets deleted. This
commit fixes this and adds the k8s namespace.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit 22a3743 ]

There is a flake in e2e test when a test case starts to proceed
before ccnp comes to take effect by cilium-agent. The correct way to
delete ccnp is to run "kubectl delete" followed by "cilium policy wait",
and kubectl helper already has such wrappers.

Fixes: #24380

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit 294bcd1 ]

There is a flake in e2e test when a test case starts to proceed
before cnp comes to take effect by cilium-agent. The correct way to
delete cnp is to run "kubectl delete" followed by "cilium policy wait",
and kubectl helper already has such wrappers.

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi jibi requested a review from a team as a code owner April 3, 2023 15:42
@jibi jibi added kind/backports This PR provides functionality previously merged into master. backport/1.12 This PR represents a backport for Cilium 1.12.x of a PR that was merged to main. labels Apr 3, 2023
@jibi
Copy link
Member Author

jibi commented Apr 3, 2023

/test-backport-1.12

Job 'Cilium-PR-K8s-1.17-kernel-4.9' failed:

Click to show.

Test Name

K8sChaosTest Restart with long lived connections TCP connection is not dropped when cilium restarts

Failure Output

FAIL: Pods are not ready after timeout

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.17-kernel-4.9 so I can create one.

@jibi jibi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 4, 2023
@squeed squeed merged commit 99f2d9a into v1.12 Apr 5, 2023
@squeed squeed deleted the pr/v1.12-backport-2023-04-03 branch April 5, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.12 This PR represents a backport for Cilium 1.12.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants