Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled cilium_bpf_map_pressure metric by default #24721

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Enabled cilium_bpf_map_pressure metric by default #24721

merged 1 commit into from
Apr 12, 2023

Conversation

vishal-chdhry
Copy link
Contributor

@vishal-chdhry vishal-chdhry commented Apr 4, 2023 •
edited

This PR enables cilium_bpf_map_pressure metric by default
@joestringer This is the same PR as #22464. Squashing commits wasn't working so I created a new PR.
Signed-off-by: Vishal Choudhary contactvishaltech@gmail.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #22401

@vishal-chdhry vishal-chdhry requested review from a team as code owners April 4, 2023 07:24
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 4, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 4, 2023
@joestringer joestringer added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Apr 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 4, 2023
@vishal-chdhry @joestringer
Enable cilium_bpf_map_pressure metric by default
9203678 
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
joestringer approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased your commit, tidied up a small clearspace issue and fixed up the commit message in git + repushed. LGTM, I'll run CI then hopefully it's good to merge.

@joestringer
Copy link
Member

joestringer commented Apr 4, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) Tests NodePort inside cluster (kube-proxy)

Failure Output

FAIL: Request from testclient-pxwth pod to service tftp://[fd04::12]:32118/hello failed

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

@qmonnet
Copy link
Member

qmonnet commented Apr 5, 2023

/mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19

@qmonnet
Copy link
Member

qmonnet commented Apr 5, 2023 •
edited

/test-1.25-4.19
Failed to reach github.com

@qmonnet qmonnet mentioned this pull request Apr 5, 2023
Closed
@qmonnet
Copy link
Member

qmonnet commented Apr 5, 2023

/test-1.25-4.19

qmonnet
qmonnet approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@qmonnet qmonnet added the area/metrics Impacts statistics / metrics gathering, eg via Prometheus. label Apr 5, 2023
@christarazi christarazi added the sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. label Apr 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 12, 2023
@pchaigno pchaigno merged commit acb28ac into cilium:master Apr 12, 2023
42 checks passed
@christarazi christarazi mentioned this pull request Aug 21, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@nebril nebril nebril approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/metrics Impacts statistics / metrics gathering, eg via Prometheus. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable cilium_bpf_map_pressure metric by default
7 participants
@vishal-chdhry @joestringer @qmonnet @nebril @tommyp1ckles @pchaigno @christarazi