pkg/service: Extend unit test cases #24742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditighag
added
the
release-note/misc
aditighag
added
needs-backport/1.12
needs-backport/1.13
aditighag
force-pushed
the
pr/aditighag/service-extend-unit-test
branch
3 times, most recently
from
a08b54c
to
1f029f5
Compare
The commit adds a unit test to delete a service with non-active backends. This is to catch any regressions (such as backend leaks) [1] in the logic that gracefully terminates such backends. [1] cilium#23858. Signed-off-by: Aditi Ghag <aditi@cilium.io>
aditighag
force-pushed
the
pr/aditighag/service-extend-unit-test
branch
from
1f029f5
to
1a0846e
Compare
squeed
approved these changes
Apr 5, 2023
|
No need to run the full CI as the PR only adds a unit test, and Travis job passed. |
aditighag
added
the
ready-to-merge
squeed
removed
the
ready-to-merge
|
This needs approval from sig-lb. |
aspsk
approved these changes
Apr 5, 2023
aditighag
added
the
ready-to-merge
pchaigno
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.12
in 1.12.9
gandro
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.2
gandro
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.