Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy: Support more envoy image tag formats #24750

Merged
merged 1 commit into from
Apr 5, 2023

Commits on Apr 5, 2023

  1. envoy: Support more envoy image tag formats

    This commit is to add the support for below image tags
    
    Different envoy image tag formats:
    
    ```
    quay.io/cilium/cilium-envoy:f195a0a836629ceca5d7561f758c9505d9ebaebfa262647a2d4
    quay.io/cilium/cilium-envoy:v1.23-f195a0a836629ceca5d7561f758c9505d9ebaebfa262647a2d4
    ```
    
    Testing was done as per below, kindly note the existing format should be
    working as usual.
    
    ```bash
    $ test=quay.io/cilium/cilium-envoy:014ceeb312a4d18dcf0ea219143f099fa91f2f28@sha256:1a3020822e8fb10b5f96bf45554690c411c2f48d8ca8fcf33da871dad1ce6b53
    $ echo $test | sed -E -e 's/[^/]*\/[^:]*:([^:@]*).*/\1/p;d' | sed -E -e 's/.*-([^-]*)$/\1/'
    014ceeb312a4d18dcf0ea219143f099fa91f2f28
    $ test=quay.io/cilium/cilium-envoy:v1.24-014ceeb312a4d18dcf0ea219143f099fa91f2f28@sha256:1a3020822e8fb10b5f96bf45554690c411c2f48d8ca8fcf33da871dad1ce6b53
    $ echo $test | sed -E -e 's/[^/]*\/[^:]*:([^:@]*).*/\1/p;d' | sed -E -e 's/.*-([^-]*)$/\1/'
    014ceeb312a4d18dcf0ea219143f099fa91f2f28
    ```
    
    Fixes: cilium#24749
    
    Signed-off-by: Tam Mach <tam.mach@cilium.io>
    sayboras committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    0b31f28 View commit details
    Browse the repository at this point in the history