loader: Don't compile .asm files by default
#24769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we always compile a .asm files for endpoints, even though we rarely use them. They take a lot of space in the sysdumps and increase the overall compile time. This commit changes it to only compile those files if debugging mode is enabled. Reported-by: Sebastian Wicki <sebastian@isovalent.com> Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
sig/loader
|
/test |
gandro
approved these changes
Apr 5, 2023
dylandreimerink
approved these changes
Apr 5, 2023
|
The net-next job hit known flake #24687. |
nickolaev
approved these changes
Apr 6, 2023
|
k8s-1.26-kernel-net-next hit a timeout while downloading the Docker images as part of the VM provisioning. I'm guessing due to some transient connectivity issue. |
|
ConformanceEKS hit known CI breakage #24774. Other tests are passing. Marking ready to merge. |
pchaigno
added
the
ready-to-merge
pchaigno
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.12
in 1.12.9
gandro
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.11
in 1.11.16
gandro
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.9
michi-covalent
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.11
to Backport done to v1.11
in 1.11.16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, we always compile a
.asmfiles for endpoints, even though we rarely use them. They take a lot of space in the sysdumps and increase the overall compile time.This pull request changes it to only compile those files if debugging mode is enabled.
Marking for backports to all branches because the change here is unlikely to conflict and should help with sysdump collection.