Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-datapath: Fix issue where test were wrongly reported as passing #24813

Merged
merged 1 commit into from
Apr 12, 2023

Commits on Apr 11, 2023

  1. ci-datapath: Fix issue where test were wrongly reported as passing

    Before this commit, the ci-datapath workflow would update the PR status
    for each `setup-and-test` matrix job. That however lead to the PR being
    marked as green as soon as the first matrix job succeeded, even though
    later tests might fail.
    
    Worse, if an earlier matrix job failed, and a later one succeeded, the
    latter job masked the failure of the earlier job and marked the PR as
    green as well.
    
    This commit fixes the issue by only updating the commit status once all
    jobs have run. This technique is taken from #23865 and has
    been used for the BPF verifier workflow for a while.
    
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    gandro committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    4813172 View commit details
    Browse the repository at this point in the history