Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid clearing objects in CiliumEndpoint conversion funcs #24928

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Avoid clearing objects in CiliumEndpoint conversion funcs #24928

merged 1 commit into from
Apr 17, 2023

Commits on Apr 17, 2023

  1. Avoid clearing objects in conversion funcs 

    This removes the behavior of mutating the objects received from the
client-go library. To begin with there isn't really any benefit from
doing so, given we don't store the object afterwards, and it will be
ready for gc when it leaves the scope inside client-go. client-go can
possibly return the same pointer twice here, to trigger eg. both an
object update delta and then a DeletedFinalStateUnknown delta with the
same pointer.

For more info, see the issue 115658 in the kubernetes/kubernetes repo on
github.

Follow-up of: 74307f1 ("Avoid clearing objects in conversion funcs")

Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    11d1086 View commit details
    Browse the repository at this point in the history