Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress: Add ownerReferences for shared mode #24942

Merged
merged 1 commit into from Apr 18, 2023
Merged

ingress: Add ownerReferences for shared mode #24942

merged 1 commit into from Apr 18, 2023

Conversation

sayboras
Copy link
Member

This commit is to make sure that you have all required ownerReferences for shared CEC, which can be useful for debugging purposes (i.e. find out which cross namespace Ingress resources). Unit test fixtures are already having owner reference information.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 18, 2023
@sayboras sayboras added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Apr 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 18, 2023
@sayboras sayboras added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. area/servicemesh GH issues or PRs regarding servicemesh labels Apr 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 18, 2023
@sayboras sayboras added the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label Apr 18, 2023
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review April 18, 2023 06:54
@sayboras sayboras requested a review from a team as a code owner April 18, 2023 06:55
@sayboras sayboras marked this pull request as draft April 18, 2023 06:57
@sayboras
ingress: Add ownerReferences for shared mode
d22eb59 
This commit is to make sure that you have all required ownerReferences
for shared CEC, which can be useful for debugging purpose (i.e. find out
which cross namespace Ingress resources). Unit test fixtures are already
having owner references information.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras marked this pull request as ready for review April 18, 2023 07:04
@sayboras
Copy link
Member Author

/test

meyskens
meyskens approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sayboras sayboras merged commit 821800b into cilium:master Apr 18, 2023
57 checks passed
@sayboras sayboras deleted the tam/ingress-owner-ref branch April 18, 2023 13:33
@nbusseneau nbusseneau mentioned this pull request Apr 20, 2023
Merged
15 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 20, 2023
@sayboras sayboras added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 26, 2023
@thorn3r thorn3r mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyskens meyskens meyskens approved these changes

@youngnick youngnick Awaiting requested review from youngnick youngnick was automatically assigned from cilium/sig-servicemesh

@jrajahalme jrajahalme Awaiting requested review from jrajahalme

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sayboras @meyskens @nbusseneau