CODEOWNERS: Add sig-foundations #24976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
joestringer
reviewed
Apr 19, 2023
pchaigno
requested changes
Apr 19, 2023
joamaki
force-pushed
the
pr/joamaki/foundations-codeowners
branch
from
0291084
to
347db46
Compare
There was a problem hiding this comment.
+1 to consideration for @joestringer's comment, otherwise LGTM from a docs perspective.
|
Given that there is feedback to address and a conflict to solve, I'm turning this PR to draft status for the time being. |
Assign pkg/{hive,statedb,promise,stream} and daemon/cmd/cells.go to
sig-foundations.
Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/foundations-codeowners
branch
from
347db46
to
a001fbd
Compare
Reverted all the reorderings. |
pchaigno
approved these changes
May 24, 2023
joestringer
approved these changes
May 24, 2023
|
The GitHub warning should be resolved now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assign pkg/{hive,statedb,promise,stream} and daemon/cmd/cells.go to sig-foundations.