-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/cmd: Move Cilium Operator version log earlier #25018
operator/cmd: Move Cilium Operator version log earlier #25018
Conversation
To be consistent with where the version log is printed in the Agent, move the Operator's log statement accordingly to be after the options are printed. This is a very minor change, but I found it much easier to find the version when it's in the usual spot that we are used to when looking at the Agent. Without this change, the version is printed after the hive framework initialization. If that fails, we wouldn't be able to see the version log anyway. Signed-off-by: Chris Tarazi <chris@isovalent.com>
/test Job 'Cilium-PR-K8s-1.16-kernel-4.19' failed: Click to show.Test Name
Failure Output
Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-kernel-4.19/1028/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Job 'Cilium-PR-K8s-1.27-kernel-net-next' failed: Click to show.Test Name
Failure Output
Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.27-kernel-net-next/48/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Edit: |
/mlh new-flake Cilium-PR-K8s-1.16-kernel-4.19 👍 created #25068 |
/test-1.16-4.19 |
/test-1.27-net-next |
To be consistent with where the version log is printed in the Agent,
move the Operator's log statement accordingly to be after the options
are printed.
This is a very minor change, but I found it much easier to find the
version when it's in the usual spot that we are used to when looking
at the Agent. Without this change, the version is printed after the hive
framework initialization. If that fails, we wouldn't be able to see the
version log anyway.
Signed-off-by: Chris Tarazi chris@isovalent.com