Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Collect sysdump as part of artifacts #25079

Merged
merged 1 commit into from May 16, 2023

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Apr 24, 2023

Once we have a sysdump in the test artifacts a lot of files we collect will become duplicates. This commit however doesn't remove all those duplicate files from the test artifacts. Let's wait a bit and confirm the sysdump collection always work before cleaning things up.

The sysdump collection was tested by making a test fail on purpose. Test run: https://jenkins.cilium.io/view/PR/job/Cilium-PR-K8s-1.16-kernel-4.19/1461/.

@pchaigno pchaigno added the release-note/ci This PR makes changes to the CI. label Apr 24, 2023
@pchaigno pchaigno force-pushed the jenkins-artifact-collect-sysdump branch 5 times, most recently from af2d2a2 to d361fe7 Compare April 27, 2023 21:21
@pchaigno pchaigno force-pushed the jenkins-artifact-collect-sysdump branch 4 times, most recently from 7478ee7 to a1da1c9 Compare May 14, 2023 14:37
Once we have a sysdump in the test artifacts a lot of files we collect
will become duplicates. This commit however doesn't remove all those
duplicate files from the test artifacts. Let's wait a bit and confirm
the sysdump collection always work before cleaning things up.

The sysdump collection was tested by making a test fail on purpose.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the jenkins-artifact-collect-sysdump branch from a1da1c9 to 7c1b797 Compare May 14, 2023 14:37
@pchaigno pchaigno marked this pull request as ready for review May 14, 2023 14:38
@pchaigno pchaigno requested a review from a team as a code owner May 14, 2023 14:38
@pchaigno pchaigno requested a review from christarazi May 14, 2023 14:38
@pchaigno
Copy link
Member Author

pchaigno commented May 15, 2023

/test-vagrant

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks N/S loadbalancing With host policy Tests NodePort

Failure Output

FAIL: Can not connect to service "http://[fd04::12]:31169" from outside cluster (1/10)

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/2300/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

@pchaigno
Copy link
Member Author

pchaigno commented May 15, 2023

This test failed due to a connectivity blip when download Ubuntu packages:
/test-1.16-4.19

@pchaigno
Copy link
Member Author

k8s-1.26-kernel-net-next failed with known flake #25411. Other CI jobs are passing. Marking ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 16, 2023
@aditighag aditighag merged commit e93fdd8 into cilium:main May 16, 2023
45 of 47 checks passed
@pchaigno pchaigno deleted the jenkins-artifact-collect-sysdump branch May 16, 2023 20:48
@pchaigno pchaigno added needs-backport/1.11 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.3 Jun 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.10 Jun 1, 2023
@pchaigno
Copy link
Member Author

pchaigno commented Jun 1, 2023

Marking for backports to help debug CI flakes. We've confirmed for the past two weeks that it works in main and pull requests.

@sayboras sayboras mentioned this pull request Jun 2, 2023
8 tasks
@YutaroHayakawa YutaroHayakawa mentioned this pull request Jun 6, 2023
3 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.12 in 1.12.10 Jun 6, 2023
@YutaroHayakawa YutaroHayakawa mentioned this pull request Jun 6, 2023
3 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.11 backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.11 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport done to v1.13 in 1.13.3 Jun 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport done to v1.13 in 1.13.3 Jun 7, 2023
@YutaroHayakawa YutaroHayakawa added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jun 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.10 Jun 8, 2023
@YutaroHayakawa YutaroHayakawa added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.12.10
Backport done to v1.12
1.13.3
Backport done to v1.13
Development

Successfully merging this pull request may close these issues.

None yet

4 participants