Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.12 backports 2023-04-26 #25138

Merged
merged 2 commits into from Apr 28, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Apr 26, 2023

Once this PR is merged, you can update the PR labels via:

$ for pr in 25043 25046; do contrib/backporting/set-labels.py $pr done 1.12; done

[ upstream commit 922aa1b ]

When using metallb as BGP speaker, if IPv6 advertisement is made - metallb will return error as unsupported.
This error is logged and error is returned to control loop, which continues retrying causing log flooding and high CPU.
This change filters out IPv6 prefixes before sending them to metallb library and logs one time error message.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras requested a review from a team as a code owner April 26, 2023 11:47
@sayboras sayboras added kind/backports This PR provides functionality previously merged into master. backport/1.12 This PR represents a backport for Cilium 1.12.x of a PR that was merged to main. labels Apr 26, 2023
[ upstream commit 46de5bc ]

These are remnants of a past before GHPRB. At best they create
uncessary noise in the logs, at worst they can interfere with the
default behaviour, so let's just remove them.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
Copy link
Member Author

sayboras commented Apr 26, 2023

/test-backport-1.12

Job 'Cilium-PR-K8s-1.17-kernel-4.9' failed:

Click to show.

Test Name

K8sIstioTest Istio Bookinfo Demo Tests bookinfo inter-service connectivity

Failure Output

FAIL: Endpoints are not ready after timeout

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.17-kernel-4.9/1324/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.17-kernel-4.9 so I can create one.

Then please upload the Jenkins artifacts to that issue.

@sayboras
Copy link
Member Author

/test-1.16-4.9

@sayboras
Copy link
Member Author

/test-1.22-4.9

@sayboras
Copy link
Member Author

/test-1.22-5.4

@sayboras
Copy link
Member Author

/test-1.24-net-next

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 26, 2023
@michi-covalent
Copy link
Contributor

mlh is helping as usual

@michi-covalent michi-covalent merged commit 4d021a5 into cilium:v1.12 Apr 28, 2023
54 of 55 checks passed
@sayboras sayboras deleted the pr/v1.12-backport-2023-04-26 branch April 28, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.12 This PR represents a backport for Cilium 1.12.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants