New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve golangci-lint usage #25157
Merged
Merged
Improve golangci-lint usage #25157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help with debugging issues reported by golangci-lint by printing the file and line number. Signed-off-by: Joe Stringer <joe@cilium.io>
Allegedly this should give us tracing information in order to debug why this action is taking so long. Signed-off-by: Joe Stringer <joe@cilium.io>
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
and removed
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
labels
Apr 27, 2023
5 tasks
joestringer
force-pushed
the
pr/joe/improve-golangci-lint
branch
from
April 27, 2023 01:08
c438b32
to
fd2f6f4
Compare
joestringer
added
the
dont-merge/preview-only
Only for preview or testing, don't merge it.
label
Apr 27, 2023
OK, with 57b4a95 it seems to generate much more usable output now:
|
Suggested-by: Casey Callendrello <cdc@isovalent.com> Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
pr/joe/improve-golangci-lint
branch
from
April 27, 2023 17:34
57b4a95
to
6a3fa1a
Compare
joestringer
removed
the
dont-merge/preview-only
Only for preview or testing, don't merge it.
label
Apr 27, 2023
viktor-kurchenko
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #25155