node/manager: Utilize set.SliceSubsetOf in ipcache deletion #25180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
added
kind/enhancement
This comment was marked as outdated.
This comment was marked as outdated.
christarazi
added
area/daemon
christarazi
changed the title
christarazi
force-pushed
the
pr/christarazi/nodemanager-ipcache-diff
branch
from
07da8ce
to
f0426a6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
christarazi
force-pushed
the
pr/christarazi/nodemanager-ipcache-diff
branch
2 times, most recently
from
d56bd82
to
47fcc78
Compare
|
/test |
pippolo84
requested changes
May 12, 2023
christarazi
force-pushed
the
pr/christarazi/nodemanager-ipcache-diff
branch
from
47fcc78
to
5e126fd
Compare
This will be used in upcoming commits when the main set can be nil. Signed-off-by: Chris Tarazi <chris@isovalent.com>
This cleans up the code to have proper diffing logic when delete node IPs from the ipcache. Previously, the logic had a potential for a bug because it assumed that oldIPs and newIPs were sorted. FWIW, no bug has been reported in regards to the previous code fixed by this commit, so it's theoretical for now. In the end, this is a defensive change to prevent it from happening. Additionally, this commit will ease the changes that will be introduced in cilium#23208. Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/nodemanager-ipcache-diff
branch
from
5e126fd
to
c56683b
Compare
|
/test |
|
Marking ready to merge as we have approving reviews and the Travis failure is due to images missing, but it's not required as the integrations test job (test the same thing AFAIK) succeeded. |
christarazi
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying the more relevant commit for ease of review: