daemon: Remove encrypt key from syncHostIPs() #25252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need for the encrypt key to be set on host IPs. Additionally, this code was also setting the encrypt key for the `0.0.0.0/0` `world` entry as well, which isn't necessary. Encryption is done for node-to-node traffic therefore it's not necessary for encrypt key to be set on local host IPs. Fixes: b698972 (cilium: ipsec, support rolling updates) Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added
kind/enhancement
christarazi
requested review from
gentoo-root,
a team and
gandro
and removed request for
a team
|
/test-runtime |
|
/test-1.25-4.19 |
gandro
approved these changes
May 4, 2023
gentoo-root
approved these changes
May 4, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
is the button green? yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need for the encrypt key to be set on host IPs. Additionally,
this code was also setting the encrypt key for the
0.0.0.0/0worldentry as well, which isn't necessary.
Encryption is done for node-to-node traffic therefore it's not necessary
for encrypt key to be set on local host IPs.
Fixes: b698972 (cilium: ipsec, support rolling updates)
Signed-off-by: Chris Tarazi chris@isovalent.com