New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Update k3s cilium installation to match k3s default podCIDR #25270
Conversation
Commit 0ef08ef83877c9410561cb60cee1fc52c6ca4b93 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commit 676055067d381c044fe89838e2aa4b3f7e7d9359 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
f334001
to
bee9502
Compare
🤔 do you think it's possible for |
it might be possible, not familiar with cilium cli and how easy to implement that, not much in autodetect for k3s https://github.com/cilium/cilium-cli/blob/main/install/autodetect.go, assume cilium cli found the podCIR, cilium cli would still do something with |
Yeah, that's the key question - If the Pod CIDR is somehow exposed through some resource for example then we could potentially implement this in an automatic way for every user of the Cilium-CLI. K3s isn't the only platform that may encounter this problem, so if we can come up with a reasonable solution for other platforms as well then we should. At the same time, I appreciate that this docs change is more immediate and practical, so I'm not against simply documenting this as an alternative. 👍 |
I agree cilium cli could be more smart to detect the cluster and setup the correct podCIDR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise LGTM. Approving preemptively with the understanding that the change must be made prior to merge.
Current k3s installation instruction allow k3s to use the default podCIDR 10.42.0.0/16 for pod, which can be seen from node.Spec: spec: podCIDR: 10.42.0.0/24 podCIDRs: - 10.42.0.0/24 but "cilium install" result in pod IP to be allocated from 10.0.0.0/8 range, this cause confusion to users, the cilium installation should allow allocated pod IP match default k3s podCIDR. Signed-off-by: Vincent Li <v.li@f5.com>
Current k3s installation instruction allow k3s to
use the default podCIDR 10.42.0.0/16 for pod, which can be seen from node.Spec:
spec:
podCIDR: 10.42.0.0/24
podCIDRs:
but "cilium install" result in pod IP to be allocated from 10.0.0.0/8 range, this cause confusion to users, the cilium installation should allow allocated pod IP match default k3s podCIDR.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #issue-number