Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf/makefile: fix spelling issue and make it clear which bear cli. #25273

Merged

Conversation

tommyp1ckles
Copy link
Contributor

Bear CLI is a bit ambiguous, specify exactly what CLI to install. Also fixes escaping so it doesn't print out ATH instead of $PATH.

@tommyp1ckles tommyp1ckles added the release-note/misc This PR makes changes that have no direct user impact. label May 4, 2023
@tommyp1ckles tommyp1ckles marked this pull request as ready for review May 4, 2023 20:24
@tommyp1ckles tommyp1ckles requested a review from a team as a code owner May 4, 2023 20:24
@tommyp1ckles tommyp1ckles requested a review from rgo3 May 4, 2023 20:24
Bear CLI is a bit ambiguous, specify exactly what CLI to install.

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles force-pushed the pr/tp/fix-and-improve-gen_compile_commands branch from 6cca499 to 412fe9b Compare May 8, 2023 20:04
@tommyp1ckles tommyp1ckles added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 10, 2023
@youngnick youngnick merged commit c571475 into cilium:main May 11, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants