daemon: Log warning if BPF Clock probe fail #25287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
the
release-note/misc
pchaigno
force-pushed
the
bpf-clock-probe-warning
branch
from
8e7aade
to
0b1597b
Compare
pchaigno
force-pushed
the
bpf-clock-probe-warning
branch
2 times, most recently
from
c5a8d26
to
8b4b24e
Compare
aspsk
reviewed
May 5, 2023
If a user enable BPF Clock and probe of the kernel support fails, we currently don't log anything and silently disable that feature. Let's instead log a warning so it's clear that the feature isn't used and why. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
bpf-clock-probe-warning
branch
from
8b4b24e
to
bc5960a
Compare
|
I see you don't trust me to fix that properly 😆 |
|
/test |
aspsk
approved these changes
May 5, 2023
|
I don't think we need to wait for more reviews. This code is in the agent but specific to the datapath. Tests are passing. Marking ready to merge. |
pchaigno
added
the
ready-to-merge
youngnick
approved these changes
May 8, 2023
maintainer-s-little-helper
bot
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user enable BPF Clock and probe of the kernel support fails, we currently don't log anything and silently disable that feature. Let's instead log a warning so it's clear that the feature isn't used and why.