Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/push charts: Checkout main branch before set-env-variables #25296

Merged
merged 1 commit into from May 9, 2023

Conversation

chancez
Copy link
Contributor

@chancez chancez commented May 5, 2023

set-env-variables may not exist on older branches, so like other github actions, checkout the default branch before calling set-env-variables.

CI run on a branch testing this change: https://github.com/cilium/cilium/actions/runs/4898128686/jobs/8746928466

set-env-variables may not exist on older branches, so like other github
actions, checkout the default branch before calling set-env-variables.

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
@chancez chancez added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels May 5, 2023
@chancez chancez self-assigned this May 5, 2023
@chancez chancez requested review from a team as code owners May 5, 2023 22:44
@chancez chancez requested a review from brlbil May 5, 2023 22:44
@michi-covalent
Copy link
Contributor

michi-covalent commented May 6, 2023

/test

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) with L4 policy Tests NodePort with L4 Policy

Failure Output

FAIL: Request from testclient-jfkmg pod to service tftp://[fd04::11]:30246/hello failed

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.25-kernel-4.19/2015/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

@michi-covalent
Copy link
Contributor

michi-covalent commented May 6, 2023

/mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19

👍 created #25300

@michi-covalent
Copy link
Contributor

/test-1.25-4.19

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 9, 2023
@michi-covalent michi-covalent merged commit 8ca0691 into main May 9, 2023
58 checks passed
@michi-covalent michi-covalent deleted the pr/chancez/push_chart_stable_branches_fix branch May 9, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants