Fix copy of annotations into CiliumNode #25307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
meyskens
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pippolo84
reviewed
May 8, 2023
|
I've tested this on my setup, and, as opposed to before, it appears to work and is actually copying the annotations, leading to a working BGP control plane. |
michi-covalent
added
needs-backport/1.13
michi-covalent
added
the
release-blocker/1.13
meyskens
force-pushed
the
meyskens/fix-bgpanno-sync
branch
from
27c1d50
to
5d1abef
Compare
pippolo84
reviewed
May 9, 2023
This fixes the adding of relevant annotations to the created CiliumNode object. This was caused by the local node not containing this info. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
meyskens
force-pushed
the
meyskens/fix-bgpanno-sync
branch
from
5d1abef
to
6c64d7f
Compare
|
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/2159/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
|
This looks good to me, I've also tested in our BGP labs 👍 |
ldelossa
approved these changes
May 9, 2023
|
CI failure seems to be related to #15455 |
|
/test-1.26-net-next |
maintainer-s-little-helper
bot
added
the
ready-to-merge
thorn3r
added
backport-pending/1.13
julianwiedmann
added
backport-done/1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the adding of relevant annotations to the created CiliumNode object. This was caused by the local node not containing this info.
Work for this regarding BGP an notations got added in #24914 but never properly synced as the localNode did store the info. this fix takes those from the received k8s node object to generate them.
Fixes: #25301