Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove govalidator dependency #25314

Merged
merged 1 commit into from May 10, 2023

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented May 8, 2023

The library github.com/asaskevich/govalidator barely sees any usage and doesn't seem to be maintained. Let's get rid of it as a direct dependency.

The library `github.com/asaskevich/govalidator` barely sees any usage
and doesn't seem to be maintained. Let's get rid of it as a direct
dependency.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added area/CI Continuous Integration testing issue or flake kind/cleanup This includes no functional changes. release-note/ci This PR makes changes to the CI. labels May 8, 2023
@rolinh rolinh requested review from a team as code owners May 8, 2023 12:43
@rolinh rolinh requested review from aanm, chancez, nebril and jibi May 8, 2023 12:44
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fascinating

@michi-covalent
Copy link
Contributor

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 10, 2023
@tklauser tklauser merged commit 7c3a2b7 into main May 10, 2023
58 checks passed
@tklauser tklauser deleted the pr/rolinh/remove-govalidator-dependency branch May 10, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants