Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarantine K8sDatapathVerifier test #25318

Closed
wants to merge 1 commit into from
Closed

Quarantine K8sDatapathVerifier test #25318

wants to merge 1 commit into from

Conversation

michi-covalent
Copy link
Contributor

Due to this flake: #25255

@michi-covalent michi-covalent added the release-note/ci This PR makes changes to the CI. label May 8, 2023
@michi-covalent michi-covalent requested a review from a team as a code owner May 8, 2023 16:07
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels May 8, 2023
@pchaigno
Copy link
Member

pchaigno commented May 8, 2023 •
edited

Oh, come on Michi. This is a one-line fix. We just need to remove the test pods before we remove Cilium. cc @tommyp1ckles

@pchaigno
Copy link
Member

pchaigno commented May 8, 2023

This is happening often now because the tests run in the same order all the time and, I'm guessing, K8sDatapathServicesTest doesn't properly clean pods after itself (most likely removes Cilium without checking that all pods have been removed).

@michi-covalent
Copy link
Contributor Author

sounds good, then i'll wait for @tommyp1ckles to open a pull request to fix this flake before closing this pull request 🚀 i just noticed people are setting ready-to-merge label manually just to ignore this flake. if it's a one line fix, totally makes sense to fix it instead 🙏

@michi-covalent
Copy link
Contributor Author

/test-backport-1.13

@michi-covalent
Copy link
Contributor Author

/test-backport-1.13

@michi-covalent
Quarantine K8sDatapathVerifier
4d38b8a 
Due to this flake: #25255

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
Copy link
Contributor Author

/test-backport-1.13

@michi-covalent
Copy link
Contributor Author

got fixed in #25255. closing.

@michi-covalent michi-covalent deleted the pr/michi/quarantine branch May 18, 2023 22:23
@pchaigno
Copy link
Member

got fixed in #25255. closing.

@michi-covalent Did you mean to link to something else?

@michi-covalent
Copy link
Contributor Author

oh yes i did 😅 the fix is in #25341, and it got backported to v1.13 in #25503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

Assignees
No one assigned
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michi-covalent @pchaigno @tommyp1ckles