Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpv1: fix issue with pod cidr advertisement removal #25320

Merged
merged 1 commit into from May 8, 2023

Conversation

harsimran-pabla
Copy link
Contributor

This change fixes diff code when there is multiple pod cidr withdrawals done at once.

Fixes issue in BGP reconciler when multiple pod cidr withdrawals are done.

This change fixes diff code when there is multiple pod cidr withdrawals.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels May 8, 2023
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner May 8, 2023 17:47
@ldelossa ldelossa added the release-blocker/1.13 This issue will prevent the release of the next version of Cilium. label May 8, 2023
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just needs tests to pass.

@harsimran-pabla
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 8, 2023
@ldelossa ldelossa merged commit a0254cd into cilium:main May 8, 2023
58 checks passed
@ldelossa ldelossa added the affects/v1.13 This issue affects v1.13 branch label May 9, 2023
@christarazi christarazi removed the backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. label May 11, 2023
@aanm
Copy link
Member

aanm commented Apr 17, 2024

I've removed the release blocker label since the 1.13 was already released.

@aanm aanm removed the release-blocker/1.13 This issue will prevent the release of the next version of Cilium. label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/v1.13 This issue affects v1.13 branch kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants