hubble: Remove spammy debug log message on lost events #25321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debug log is enabled, and in particular when monitor aggregation is disabled [1], this debug message tends to spam the agent logs. Instead of rate-limiting it, given we already have a metric for the same [2], let's just remove it. 1 - This combination of debug enabled and monitor aggregation disabled is very frequent on datapath debugging sessions. 2 - The hubble_lost_events_total metric. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
pchaigno
added
release-note/misc
kaworu
approved these changes
May 9, 2023
|
I don't think we need to run the full end-to-end tests for this simple removal of a debug log, so marking ready to merge. |
pchaigno
added
the
ready-to-merge
JAORMX
approved these changes
May 9, 2023
lambdanis
approved these changes
May 9, 2023
lambdanis
approved these changes
May 9, 2023
learnitall
added
the
needs-backport/1.13
|
Hey! I'd like to have this backported to 1.13.6, please. This debug log can have a negative impact on CPU utilization, see #27661 |
gandro
added
backport-pending/1.13
julianwiedmann
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport done to v1.13
in 1.13.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debug log is enabled, and in particular when monitor aggregation is disabled [1], this debug message tends to spam the agent logs. Instead of rate-limiting it, given we already have a metric for the same (
hubble_lost_events_total), let's just remove it.1 - This combination of debug enabled and monitor aggregation disabled is very frequent on datapath debugging sessions.