gh/workflow: change multicluster GKE cluster provisioning to none blocking mode #25394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
brlbil
force-pushed
the
pr/brlbil/provision-gke-cluster-async
branch
2 times, most recently
from
d41e5ad
to
b9ec82a
Compare
Multicluster conformance tests set up two clusters in blocking mode and sequentially. Every cluster provisioning takes 4 to 5 min. This commit changes provisioning to none blocking mode and adds a step to wait for provisioning to finish. This change would cut the run time by 4 to 5 min. Signed-off-by: Birol Bilgin <birol@cilium.io>
brlbil
force-pushed
the
pr/brlbil/provision-gke-cluster-async
branch
from
b9ec82a
to
b413a7f
Compare
|
There is no need for full CI since changes are only to workflow files. |
brlbil
added
ready-to-merge
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
nbusseneau
approved these changes
May 12, 2023
| @@ -243,7 +243,8 @@ jobs: | |||
| --disk-type pd-standard \ | |||
| --disk-size 10GB \ | |||
| --node-taints node.cilium.io/agent-not-ready=true:NoExecute \ | |||
| --preemptible | |||
| --preemptible \ | |||
| --async | |||
There was a problem hiding this comment.
Nice, they finally added this!
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multicluster conformance tests set up two clusters sequentially. Every cluster provisioning takes 4 to 5 min.
This PR changes provisioning to none blocking mode and adds a step to wait for provisioning to finish.
This change would cut the run time by 4 to 5 min, it is small but every bit helps.
Sucessful workflow runs.
conformance-multicluster-v1.11.yaml
conformance-multicluster-v1.12.yaml
conformance-multicluster-v1.13.yaml