Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: scripts to update and check envoy image version #25413

Conversation

mhofstetter
Copy link
Member

check

This commit introduces a linter which checks for differences of the Cilium Envoy image version between the Cilium Dockerfile (embedded) and the Cilium Helm Chart (DaemonSet).

In addition, the linter gets added to the CI GH Action lint-images-base.

update

This commit introduces the script update-cilium-envoy-image.sh (and corresponding make target) which fetches the latest cilium-envoy image by getting the relevant data from its github repo.

It updates the cilium Dockerfile (embedded) and the Helm values.yaml.tmpl (DaemonSet).

-> This script is executed manually on demand

This commit introduces a linter which checks for differences of the
Cilium Envoy image version between the Cilium Dockerfile (embedded) and
the Cilium Helm Chart (DaemonSet).

In addition, the linter gets added to the CI GH Action lint-images-base.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit introduces the script `update-cilium-envoy-image.sh` (and
corresponding make target) which fetches the latest cilium-envoy image
by fetching the relevant data from its github repo.

It updates the cilium Dockerfile (embedded) and the Helm
values.yaml.tmpl (DaemonSet).

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter added area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/misc This PR makes changes that have no direct user impact. labels May 12, 2023
@mhofstetter mhofstetter requested review from a team as code owners May 12, 2023 12:19
@mhofstetter
Copy link
Member Author

/test

Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@jrajahalme jrajahalme merged commit 1398f5e into cilium:main May 15, 2023
59 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/cilium-envoy-image-update-and-check branch May 15, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants