Update push-chart workflow concurrency group #25431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we're seeing unintended cancellations of this workflow because it's a workflow_run event in most cases and github.event.after might not be working as we expect. First, add the event name into the concurrency group and then use a different ref based on the event type based on the git SHA the image chart will use for the image tags. This ensures we'll get one build for each image build but if we re-run the same job with the same parameters it'll cancel any previous invocations with for the same ref and event type. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
added
area/CI
christarazi
approved these changes
May 12, 2023
brlbil
approved these changes
May 22, 2023
chancez
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we're seeing unintended cancellations of this workflow because it's a workflow_run event in most cases and github.event.after might not be working as we expect.
First, add the event name into the concurrency group and then use a different ref based on the event type based on the git SHA the image chart will use for the image tags. This ensures we'll get one build for each image build but if we re-run the same job with the same parameters it'll cancel any previous invocations with for the same ref and event type.