Revert "gh/workflow: Run GKE workflow in matrix strategy" #25464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 9c152689ba703b8cf1ce2966bfd2a9ea7ee9b296 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
This reverts commit 4a92f1a. Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
thorn3r
force-pushed
the
revert-25364-pr/brlbil/ci-run-gke-conformance-in-parallel
branch
from
9c15268
to
534855d
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
force-pushed to add sign-off |
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
joestringer
approved these changes
May 15, 2023
|
I see this was suggested by @nbusseneau on Slack, and it seems like it should help to stabilize CI for this job. Seems safe since we were previously running successfully with the earlier version. Given that this is a revert for a PR that we believe is breaking CI, I think this is reasonable to merge as-is without further testing or review. CC @brlbil @viktor-kurchenko |
joestringer
deleted the
revert-25364-pr/brlbil/ci-run-gke-conformance-in-parallel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #25364 due to CI failures:
https://github.com/cilium/cilium/actions/runs/4983577990/jobs/8920912559
https://github.com/cilium/cilium/actions/runs/4983089307
https://github.com/cilium/cilium/actions/runs/4983592830
https://github.com/cilium/cilium/actions/runs/4983122154
@nbusseneau mentioned we will need to create ad-hoc subnetworks to prevent this