New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: disable host dns resolver for minikube installation guide #25569
Conversation
Commit ca33df8889a66f2bab2279ec76b992a2fc122d68 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
The following change also works: $ cilium install --helm-set ipam.operator.clusterPoolIPv4PodCIDR=172.16.0.0/12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks. I have some minor nits on capitalisation (see below), but it's not blocking.
Can you please sign off your commit, as explained by the bot? |
Commit ca33df8889a66f2bab2279ec76b992a2fc122d68 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Thanks for the update! I see your second commit is signed off, but not the first. Can you please do the following:
I can help if necessary. |
4589218
to
140351e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it appears that github bot requested a bunch of reviewers as a result
No worries, it's not the first time this kind of things happens, nor will it be the last :). Thanks for fixing the PR and updating your commit!
Documentation change only, and related tests passed, so I'm marking as ready-to-merge.
When
virtualbox
provider is used as minikube driver, all the VM instances are going to have10.0.2.3
as dns server (inspected by looking at/etc/resolv.conf
). This seems to have collapsed with cilium cni cidr. This is going to fail thecilium connectivity test
because image pulling are going to fail due to dns resolution failure to image registry.The fix here is to specify
--host-dns-resolver=false
so that such problem doesn't occur. The new dns resolver will be192.168.0.1
(all with default configurations).I also thought about customizing cilium cni cidr, but that may involve more changes to the doc. It might not be worthwhile in this quick installation guide.