crd: Refactor RegisterCRDsCell to be extensible #25590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippolo84
added
area/operator
pippolo84
force-pushed
the
pr/pippolo84/extensible-crd-registration-cell
branch
from
65e00e4
to
f81da27
Compare
joamaki
approved these changes
May 23, 2023
Actually, I wasn't completely satisfied by the package level variable and tried the group approach. |
pippolo84
force-pushed
the
pr/pippolo84/extensible-crd-registration-cell
branch
from
f81da27
to
c235bba
Compare
pippolo84
force-pushed
the
pr/pippolo84/extensible-crd-registration-cell
branch
from
c235bba
to
1f90e40
Compare
joamaki
approved these changes
May 24, 2023
Current implementation of RegisterCRDsCell is strictly tied to the registration of the CRDs belonging to the "cilium.io" group. This commit refactors the cell to make it easily extendable if other groups needs to register their CRDs at operator startup. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
force-pushed
the
pr/pippolo84/extensible-crd-registration-cell
branch
from
1f90e40
to
1b61b53
Compare
|
/test |
|
External workloads flake tracked in #25736, going to rerun. |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of RegisterCRDsCell is strictly tied to the registration of the CRDs belonging to the "cilium.io" group.
This PR refactors the cell to make it easily extendable if other groups needs to register their CRDs at operator startup.