probes: use veth device for probing managed neighbor support #25598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-mo
added
the
release-note/misc
rgo3
approved these changes
May 22, 2023
|
/test |
|
/test-1.26-net-next Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/67/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
|
net-next is hitting #25524, applying ready-to-merge |
ti-mo
added
the
ready-to-merge
squeed
reviewed
May 25, 2023
ti-mo
force-pushed
the
tb/managed-neighbors-veth
branch
from
760a834
to
32348dc
Compare
ti-mo
removed
the
ready-to-merge
|
/test |
derailed
added a commit
to derailed/cilium
that referenced
this pull request
May 25, 2023
- Add Timo's update to resolve issue (cilium#25598) Signed-off-by: Fernand <fernand.galiana@isovalent.com>
ti-mo
force-pushed
the
tb/managed-neighbors-veth
branch
from
32348dc
to
fb3b67c
Compare
|
/test |
Some distributions don't ship with dummy device support/module, leading to the following error when probing for managed neighbors: ``` level=fatal msg="failed to probe managed neighbor support" error="failed to add dummy link: operation not supported" subsys=probes ``` This patch uses a veth device instead, which should be available on nodes running Cilium, if it's not already loaded. Signed-off-by: Timo Beckers <timo@isovalent.com> Reported-by: Fernand Galiana <fernand.galiana@isovalent.com>
ti-mo
force-pushed
the
tb/managed-neighbors-veth
branch
from
fb3b67c
to
fd41f0f
Compare
|
/test |
|
/test-1.26-net-next |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some distributions don't ship with dummy device support/module, leading to the following error when probing for managed neighbors:
This patch uses a veth device instead, which should be available on nodes running Cilium, if it's not already loaded.