Fix CIDR json tag in CNP CIDRRule #25617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the omitempty tag, the following valid policy:
```
apiVersion: "cilium.io/v2"
kind: CiliumNetworkPolicy
metadata:
name: "echo-ingress-from-cidr-group-ref"
namespace: "default"
spec:
description: "Allow echo pods to receive ingress traffic from a specific CIDR Group"
endpointSelector:
matchLabels:
kind: echo
ingress:
- fromCIDRSet:
- cidrGroupRef: "connectivity-test-cidr-group"
```
cannot be correctly decoded from YAML:
```
CiliumNetworkPolicy.cilium.io "echo-ingress-from-cidr-group-ref" is invalid: [spec.ingress.fromCIDRSet.cidr: Invalid value: "": spec.ingress.fromCIDRSet.cidr in body should match '^(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\/([0-9]|[1-2][0-9]|3[0-2])$|^s*((([0-9A-Fa-f]{1,4}:){7}(:|([0-9A-Fa-f]{1,4})))|(([0-9A-Fa-f]{1,4}:){6}:([0-9A-Fa-f]{1,4})?)|(([0-9A-Fa-f]{1,4}:){5}(((:[0-9A-Fa-f]{1,4}){0,1}):([0-9A-Fa-f]{1,4})?))|(([0-9A-Fa-f]{1,4}:){4}(((:[0-9A-Fa-f]{1,4}){0,2}):([0-9A-Fa-f]{1,4})?))|(([0-9A-Fa-f]{1,4}:){3}(((:[0-9A-Fa-f]{1,4}){0,3}):([0-9A-Fa-f]{1,4})?))|(([0-9A-Fa-f]{1,4}:){2}(((:[0-9A-Fa-f]{1,4}){0,4}):([0-9A-Fa-f]{1,4})?))|(([0-9A-Fa-f]{1,4}:){1}(((:[0-9A-Fa-f]{1,4}){0,5}):([0-9A-Fa-f]{1,4})?))|(:(:|((:[0-9A-Fa-f]{1,4}){1,7}))))(%.+)?s*/([0-9]|[1-9][0-9]|1[0-1][0-9]|12[0-8])$', : Invalid value: "": "spec.ingress.fromCIDRSet" must validate one and only one schema (oneOf). Found 2 valid alternatives]
```
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
added
sig/k8s
nathanjsweet
approved these changes
May 23, 2023
nathanjsweet
approved these changes
May 23, 2023
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the omitempty tag, the following valid policy:
cannot be correctly decoded from YAML using an
UniversalDeserializerfromruntime/serializer.