Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify feature probing packages #25627

Merged
merged 3 commits into from
May 29, 2023
Merged

Unify feature probing packages #25627

merged 3 commits into from
May 29, 2023

Commits on May 26, 2023

  1. probe: remove HaveFullLPM feature probe 

    Since Cilium's minimal required kernel version was bumped to 4.19 all
supported kernels have full LPM map support. This allows us to remove
this feature probe as it would always be true.

Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
    @rgo3 @ti-mo
    rgo3 authored and ti-mo committed May 26, 2023
    Configuration menu
    Copy the full SHA
    8256362 View commit details
    Browse the repository at this point in the history

  2. prefilter: remove config struct 

    With the removal of HaveFullLPM every field in the prefilter config
struct will always be true. This allows the removal of all logic checks
based on those fields and the config struct itself.

Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
    @rgo3 @ti-mo
    rgo3 authored and ti-mo committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3f13ceb View commit details
    Browse the repository at this point in the history

  3. probes: migrate leftover API from pkg/probe 

    This also refactors HaveIPv6Support into returning an error instead of a
bool to keep feature probing APIs consistent across the package and adds
a small test for the probe.

Fixes: cilium#25621.

Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
    @rgo3 @ti-mo
    rgo3 authored and ti-mo committed May 26, 2023
    Configuration menu
    Copy the full SHA
    1e41a91 View commit details
    Browse the repository at this point in the history