Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing LB IPAM description in the operator document #25696

Merged
merged 2 commits into from May 30, 2023
Merged

Add missing LB IPAM description in the operator document #25696

merged 2 commits into from May 30, 2023

Conversation

YutaroHayakawa
Copy link
Member

LB IPAM description was missing from the operator document. Also, the list of CRDs was out-of-date.

Add missing LB IPAM description in the operator document

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 26, 2023
@YutaroHayakawa YutaroHayakawa added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels May 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 26, 2023
@YutaroHayakawa YutaroHayakawa marked this pull request as ready for review May 26, 2023 00:29
@YutaroHayakawa YutaroHayakawa requested review from a team as code owners May 26, 2023 00:29
joestringer
joestringer requested changes May 26, 2023
View reviewed changes
Documentation/internals/cilium_operator.rst Outdated Show resolved Hide resolved
Documentation/internals/cilium_operator.rst Outdated Show resolved Hide resolved
Documentation/internals/cilium_operator.rst Show resolved Hide resolved
@YutaroHayakawa
docs: Add missing CRDs to internals/cilium_operator.rst
5f78ab1 
Some CRDs were missing from the list of CRDs the operator registers.
Update it with the latest list of CRDs.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
@YutaroHayakawa
docs: Add description for LB IPAM in operator doc
5176a49 
Operator manages LB IPs when LB IPAM feature is used. Describe it in
operator doc.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 30, 2023
Closed
3 tasks
qmonnet
qmonnet approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the understanding that automation comes in a follow-up PR, I'm all good with the changes here. Thanks!

@joestringer joestringer merged commit f2949c9 into cilium:main May 30, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@qmonnet qmonnet qmonnet approved these changes

@joamaki joamaki Awaiting requested review from joamaki joamaki is a code owner automatically assigned from cilium/operator

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YutaroHayakawa @joestringer @qmonnet