Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: delete ginkgo test "NodePort with L7 Policy from outside" #25702

Merged
merged 1 commit into from May 26, 2023

Conversation

jschwinger233
Copy link
Member

The test case was introduced to cover issue #21954, but it turned out the test is buggy and caused a number of CI flakes (#25119). Consequently, PR #25236 put the test case under quarantine.

This commit removes that problematic test, as the target scenario has been covered by connectivity test in cilium-cli
(cilium/cilium-cli#1547).

Fixes: #25119

The test case was introduced to cover issue cilium#21954, but it turned out
the test is buggy and caused a number of CI flakes (cilium#25119).
Consequently, PR cilium#25236 put the test case under quarantine.

This commit removes that problematic test, as the target scenario has
been covered by connectivity test in cilium-cli
(cilium/cilium-cli#1547).

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 26, 2023
@jschwinger233 jschwinger233 added the release-note/ci This PR makes changes to the CI. label May 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 26, 2023
@jschwinger233 jschwinger233 added kind/bug/CI This is a bug in the testing code. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.3 May 26, 2023
@jschwinger233 jschwinger233 marked this pull request as ready for review May 26, 2023 06:22
@jschwinger233 jschwinger233 requested review from a team as code owners May 26, 2023 06:22
@jschwinger233 jschwinger233 requested review from jibi and nebril May 26, 2023 06:22
@jschwinger233
Copy link
Member Author

/test

@brb
Copy link
Member

brb commented May 26, 2023

The Jenkins CI jobs passed. Marking as ready-to-merge.

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 26, 2023
@brb brb merged commit eb5bf06 into cilium:main May 26, 2023
46 checks passed
@sayboras sayboras mentioned this pull request May 28, 2023
10 tasks
@sayboras sayboras added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport done to v1.13 in 1.13.3 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.13.3
Backport done to v1.13
4 participants