kvstore: fix TestWorkqueueSyncStoreMetrics flake #25706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a flake observed in the CI:
Error Trace: /home/travis/gopath/src/github.com/cilium/cilium/pkg/kvstore/store/syncstore_test.go:392
Error: Not equal:
expected: 1
actual : 2
Test: TestWorkqueueSyncStoreMetrics
This flake was caused by a race condition concerning setting and reading
the metric, and it is addressed asserting that the metric *eventually*
matches the expected value.
Additionally, all timeouts are raised to prevent the occurrence of flakes
when running in a noisy CI environment.
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
release-note/ci
tklauser
approved these changes
May 26, 2023
|
/test-runtime |
|
This PR only touches integration tests, and the all the related suites completed successfully. Review is in. Marking as ready to merge without running the full E2E suites. |
giorio94
added
the
ready-to-merge
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a flake observed in the CI:
This flake was caused by a race condition concerning setting and reading the metric, and it is addressed asserting that the metric eventually matches the expected value.
Additionally, all timeouts are raised to prevent the occurrence of flakes when running in a noisy CI environment.