Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface agent modules health from cilium status command #25714

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Surface agent modules health from cilium status command #25714

merged 3 commits into from
Jul 21, 2023

Conversation

derailed
Copy link
Contributor

@derailed derailed commented May 26, 2023 •
edited by christarazi

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
  • Add hive module health injection to support for module health reporting (pulled from @joamaki prototype)
  • Add swagger health apis
  • Surface agent modules health via agent CLI

There are dependencies here on these 2 PRs: #25725, #25662

Signed-off-by: Fernand Galiana fernand.galiana@isovalent.com

Augments `cilium status` CLI to report on agent modules health status.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 26, 2023
@derailed derailed force-pushed the feat/health branch 2 times, most recently from 763025f to 97b79d6 Compare May 26, 2023 13:49
@maintainer-s-little-helper
Copy link

Commit b8861da113ee9104dd94d2ca154c411f6aeddea1 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 26, 2023
@maintainer-s-little-helper
Copy link

Commit 316102cbda9bc1da18e28df299f4f128c248af50 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 26, 2023
@maintainer-s-little-helper
Copy link

Commit 316102cbda9bc1da18e28df299f4f128c248af50 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 26, 2023
@derailed derailed force-pushed the feat/health branch 6 times, most recently from f9dce79 to 77adb1a Compare May 31, 2023 15:24
@derailed derailed changed the title Add CLI command to surface agent modules health Surface agent modules health from cilium status command May 31, 2023
@derailed derailed force-pushed the feat/health branch 6 times, most recently from e1e1504 to 5626e27 Compare May 31, 2023 19:35
@tommyp1ckles
Copy link
Contributor

/test

@derailed derailed force-pushed the feat/health branch 3 times, most recently from 5abf542 to dfc9e3b Compare June 1, 2023 16:12
@derailed
Copy link
Contributor Author

/test

@christarazi
Copy link
Member

@nathanjsweet Could you take another look?

@derailed derailed force-pushed the feat/health branch 2 times, most recently from 68c065d to a1e95e8 Compare July 19, 2023 11:32
@derailed
Copy link
Contributor Author

/test

@derailed
Copy link
Contributor Author

/test

1 similar comment
@derailed
Copy link
Contributor Author

/test

@christarazi christarazi added area/health Relates to the cilium-health component area/modularization labels Jul 19, 2023
@christarazi
Copy link
Member

/test

@derailed
Copy link
Contributor Author

/test

@derailed derailed force-pushed the feat/health branch 2 times, most recently from dcbcf3b to 3ccadae Compare July 20, 2023 21:13
@derailed
Copy link
Contributor Author

/test

@christarazi
Copy link
Member

@derailed I see that this PR is getting rebased quite often. It's not necessary to rebase unless there's a merge conflict. AFAIK, GitHub will signal if that's the case.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 20, 2023
@derailed
Add agent health endpoint
0b30517 
We need a new endpoint to collect modules health status via the agent api.
This will be used initialy by the `cilium status` command to hydrate a new
section listing out all instrumented modules health.

- Update swagger config to surface health endpoint

Signed-off-by: Fernand Galiana <fernand.galiana@isovalent.com>
@derailed
Fake out node manager module to report health
03d7845 
- Add fake health report for testing

> NOTE: This will need to be updated based on PR
(cilium#25725).

Signed-off-by: Fernand Galiana <fernand.galiana@isovalent.com>
@derailed
Add modules health report
08c0337 
The agent status CLI command needs to be able to output modules health information.
As we begin implementing modules health status reporting, we need a new
health section in the CLI output to present users with modules status
specifics.

- Surface agent modules health on the `cilium status` command

Signed-off-by: Fernand Galiana <fernand.galiana@isovalent.com>
@derailed
Copy link
Contributor Author

/test

@christarazi christarazi merged commit 474acd9 into cilium:main Jul 21, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asauber asauber asauber approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles left review comments

@nathanjsweet nathanjsweet nathanjsweet approved these changes

@rolinh rolinh rolinh approved these changes

@zacharysarah zacharysarah zacharysarah approved these changes

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

@qmonnet qmonnet qmonnet approved these changes

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
area/health Relates to the cilium-health component area/modularization kind/feature This introduces new functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet