Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: nodeEncryption is only supported with WireGuard #25770

Merged

Conversation

gandro
Copy link
Member

@gandro gandro commented May 30, 2023

This commit fixes an outdated comment in our Helm values.yaml file. Originally, node-to-node encryption was a beta feature only supported with IPSec. However, since then, we have removed the IPSec support (#21333), but have added support in WireGuard instead (#19401).

Fixes: 5e98037 ("cmd: Unhide node-encryption flag")

This commit fixes an outdated comment in our Helm `values.yaml` file.
Originally, node-to-node encryption was a beta feature only supported
with IPSec. However, since then, we have removed the IPSec support
(cilium#21333), but have added support in WireGuard instead (cilium#19401).

Fixes: 5e98037 ("cmd: Unhide node-encryption flag")

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/misc This PR makes changes that have no direct user impact. area/helm Impacts helm charts and user deployment experience labels May 30, 2023
@gandro gandro requested review from a team as code owners May 30, 2023 16:00
@gandro gandro requested a review from sayboras May 30, 2023 16:00
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gandro
Copy link
Member Author

gandro commented May 31, 2023

@gandro gandro added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 31, 2023
@julianwiedmann julianwiedmann merged commit cff7195 into cilium:main May 31, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. area/helm Impacts helm charts and user deployment experience ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants