Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick up the latest startup-script image #25774

Merged
merged 1 commit into from May 31, 2023
Merged

Pick up the latest startup-script image #25774

merged 1 commit into from May 31, 2023

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented May 30, 2023 •
edited

Upgrading this image is not automated yet.

Ref: #25773
Ref: cilium/image-tools#218
Ref: https://quay.io/repository/cilium/startup-script?tab=tags

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 30, 2023
@michi-covalent michi-covalent added the release-note/ci This PR makes changes to the CI. label May 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 30, 2023
@michi-covalent
Copy link
Contributor Author

i think we can consider this a security relevant fix. i'll set backport labels accordingly.

@michi-covalent michi-covalent added needs-backport/1.11 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.3 May 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.10 May 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.11.18 May 30, 2023
@michi-covalent
Copy link
Contributor Author

/test

@michi-covalent michi-covalent marked this pull request as ready for review May 30, 2023 23:57
@michi-covalent michi-covalent requested review from a team as code owners May 30, 2023 23:57
sayboras
sayboras approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment as per below

install/kubernetes/Makefile.values Outdated Show resolved Hide resolved
@michi-covalent michi-covalent marked this pull request as draft May 31, 2023 00:38
@michi-covalent
Pick up the latest startup-script image
e373baa 
Upgrading this image is not automated yet.

Ref: #25773
Ref: cilium/image-tools#218
Ref: https://quay.io/repository/cilium/startup-script?tab=tags

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
Copy link
Contributor Author

/test

@michi-covalent
Copy link
Contributor Author

test-1.25-4.19: a transient failure downloading something from github. re-triggering...

Unable to download helm chart v1.13 from GitHub
Expected command: mkdir -p /home/jenkins/workspace/Cilium-PR-K8s-1.25-kernel-4.19/src/github.com/cilium/cilium/old-charts/v1.13 && cd /home/jenkins/workspace/Cilium-PR-K8s-1.25-kernel-4.19/src/github.com/cilium/cilium/old-charts/v1.13 && rm -rf * && wget https://github.com/cilium/cilium/archive/refs/heads/v1.13.tar.gz && tar -xf v1.13.tar.gz

@michi-covalent
Copy link
Contributor Author

/test-1.25-4.19

@michi-covalent michi-covalent marked this pull request as ready for review May 31, 2023 22:51
@michi-covalent michi-covalent merged commit 5c9b66c into main May 31, 2023
61 checks passed
@michi-covalent michi-covalent deleted the pr/michi/startup branch May 31, 2023 22:51
@sayboras sayboras mentioned this pull request Jun 2, 2023
Merged
8 tasks
@sayboras sayboras added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.13 in 1.13.4 Jun 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.11 Jun 2, 2023
@YutaroHayakawa YutaroHayakawa mentioned this pull request Jun 6, 2023
Merged
3 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.12 in 1.12.11 Jun 6, 2023
@YutaroHayakawa YutaroHayakawa mentioned this pull request Jun 6, 2023
Merged
3 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.11 in 1.11.18 Jun 6, 2023
@YutaroHayakawa YutaroHayakawa added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jun 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.4 Jun 7, 2023
@YutaroHayakawa YutaroHayakawa added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jun 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.11 Jun 8, 2023
@qmonnet qmonnet mentioned this pull request Jun 9, 2023
Closed
@michi-covalent michi-covalent mentioned this pull request Jun 9, 2023
Closed
@YutaroHayakawa YutaroHayakawa added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jun 12, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.11 to Backport done to v1.11 in 1.11.18 Jun 12, 2023
This was referenced Jun 12, 2023
Closed
Merged
Merged
Merged
@nathanjsweet nathanjsweet moved this from Needs backport from main to Backport done to v1.13 in 1.13.3 Nov 12, 2023
@nathanjsweet nathanjsweet moved this from Needs backport from main to Backport done to v1.12 in 1.12.10 Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@youngnick youngnick Awaiting requested review from youngnick youngnick is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.11.18
Backport done to v1.11
1.12.10
Backport done to v1.12
1.12.11
Backport done to v1.12
1.13.3
Backport done to v1.13
1.13.4
Backport done to v1.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michi-covalent @sayboras @YutaroHayakawa