Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add missing backslash in Helm command #25800

Merged
merged 1 commit into from May 31, 2023
Merged

docs: Add missing backslash in Helm command #25800

merged 1 commit into from May 31, 2023

Conversation

james0209
Copy link
Contributor

@james0209 james0209 commented May 31, 2023 •
edited

Adds missing backslash to Helm command in the AWS CNI-chaining documentation.

@james0209 james0209 requested review from a team as code owners May 31, 2023 15:42
@maintainer-s-little-helper
Copy link

Commit f6c717a6cfeca02d19e653449a46d98294587227 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 31, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 31, 2023
@christarazi christarazi added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels May 31, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 31, 2023
christarazi
christarazi approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please sign-off your commit?

@james0209
Add missing backslash to AWS CNI-chaining Documentation
6cc45b8 
Signed-off-by: James Brookes <jbrookes@confluent.io>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 31, 2023
qmonnet
qmonnet approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qmonnet
Copy link
Member

qmonnet commented May 31, 2023

Doc change only, no need to run the full CI suite.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 31, 2023
@julianwiedmann julianwiedmann merged commit d4d6d2c into cilium:main May 31, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@james0209 @qmonnet @christarazi @julianwiedmann