auth: temporarily disable node-based auth gc #26073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
the
release-note/misc
|
/test |
|
/test |
mhofstetter
force-pushed
the
pr/mhofstetter/test-disable-auth
branch
from
26f6017
to
33ee6c3
Compare
|
/test |
1 similar comment
|
/test |
mhofstetter
force-pushed
the
pr/mhofstetter/test-disable-auth
branch
from
33ee6c3
to
cfdab63
Compare
mhofstetter
changed the title
Currently, auth map garbage collection based on deleted node events provokes issues in combination with enabled encryption. The actual problem is that there are combinations where garbage collection unintentionally allocates node ids when trying to resolve the node IDs for a given node IP. This results in multiple node ids for the same ip, which breaks encryption. Therefore, this commit temporarily disables auth map garbage collection based on deleted node events. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/test-disable-auth
branch
from
cfdab63
to
f0b4282
Compare
mhofstetter
added
kind/bug
|
/test |
mhofstetter
changed the title
|
/ci-multicluster |
|
/ci-external-workloads |
maintainer-s-little-helper
bot
added
the
ready-to-merge
jrajahalme
approved these changes
Jun 13, 2023
8 tasks
mhofstetter
added a commit
to mhofstetter/cilium
that referenced
this pull request
Jun 15, 2023
This commit re-enables the node-based auth map garbage collection which have been temporarily disabled with cilium#26073. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
joestringer
pushed a commit
that referenced
this pull request
Jun 15, 2023
This commit re-enables the node-based auth map garbage collection which have been temporarily disabled with #26073. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
romanspb80
pushed a commit
to romanspb80/cilium
that referenced
this pull request
Jun 22, 2023
This commit re-enables the node-based auth map garbage collection which have been temporarily disabled with cilium#26073. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, auth map garbage collection based on deleted node events provokes issues in combination with enabled encryption.
The actual problem is that there are combinations where garbage collection unintentionally allocates node ids when trying to resolve the node IDs for a given node IP. This results in multiple node ids for the same ip, which breaks encryption.
Therefore, this commit temporarily disables auth map garbage collection based on deleted node events.
Fixes: #25964