Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy: Use embedded proxylib from cilium-proxy image #26101

Merged
merged 4 commits into from
Jun 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,6 @@ jenkinsfiles @cilium/ci-structure
/pkg/versioncheck/ @cilium/sig-agent
/plugins/cilium-cni/ @cilium/sig-k8s
/plugins/cilium-docker/ @cilium/docker
/proxylib/ @cilium/proxy
/README.rst @cilium/docs-structure
/SECURITY.md @cilium/contributing
/stable.txt @cilium/tophat
Expand Down
2 changes: 1 addition & 1 deletion Documentation/helm-values.rst

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Documentation/security/network/proxy/envoy.rst
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ Known Limitations
=================

- Due to Pod-to-Pod communication with the Cilium Agent via UNIX domain sockets, Envoy DaemonSet isn't supported with SELinux enabled on the host. This is the default for Red Hat OpenShift.
- Go Extensions (ProxyLib) aren't supported yet.

*************
Go Extensions
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ debug: all

include Makefile.defs

SUBDIRS_CILIUM_CONTAINER := proxylib envoy bpf cilium daemon cilium-health bugtool tools/mount tools/sysctlfix
SUBDIRS_CILIUM_CONTAINER := envoy bpf cilium daemon cilium-health bugtool tools/mount tools/sysctlfix
SUBDIR_OPERATOR_CONTAINER := operator

# Add the ability to override variables
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ require (
github.com/cilium/fake v0.4.0
github.com/cilium/kafka v0.0.0-20180809090225-01ce283b732b
github.com/cilium/lumberjack/v2 v2.3.0
github.com/cilium/proxy v0.0.0-20230605062141-384b5008dce4
github.com/cilium/proxy v0.0.0-20230623092907-8fddead4e52c
github.com/cilium/workerpool v1.2.0
github.com/containernetworking/cni v1.1.2
github.com/containernetworking/plugins v1.3.0
Expand Down
20 changes: 2 additions & 18 deletions go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion images/cilium/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ ARG CILIUM_RUNTIME_IMAGE=quay.io/cilium/cilium-runtime:872b2f51be25274a0ce2261d0

# cilium-envoy from github.com/cilium/proxy
#
FROM quay.io/cilium/cilium-envoy:v1.25.7-384b5008dce426eba89af8ef17f52e4fb066ff40@sha256:f165787c05050a4d57c5940dcd59de03cafecff9c02965a1d076c2b2935505d8 as cilium-envoy
FROM quay.io/cilium/cilium-envoy:v1.25.7-8fddead4e52c704a6b189e3f80a69403c6cdc997@sha256:7edab48930186cc988baa6fb2ef6c352325306f0d6a0c89e43bef28941189095 as cilium-envoy

#
# Hubble CLI
Expand Down
2 changes: 1 addition & 1 deletion install/kubernetes/cilium/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions install/kubernetes/cilium/values.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions install/kubernetes/cilium/values.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -1830,9 +1830,9 @@ envoy:
image:
override: ~
repository: "quay.io/cilium/cilium-envoy"
tag: "v1.25.7-384b5008dce426eba89af8ef17f52e4fb066ff40"
tag: "v1.25.7-8fddead4e52c704a6b189e3f80a69403c6cdc997"
pullPolicy: "${PULL_POLICY}"
digest: "sha256:f165787c05050a4d57c5940dcd59de03cafecff9c02965a1d076c2b2935505d8"
digest: "sha256:7edab48930186cc988baa6fb2ef6c352325306f0d6a0c89e43bef28941189095"
useDigest: true

# -- Additional containers added to the cilium Envoy DaemonSet.
Expand Down
2 changes: 1 addition & 1 deletion pkg/envoy/accesslog_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ import (
"time"

cilium "github.com/cilium/proxy/go/cilium/api"
kafka_api "github.com/cilium/proxy/pkg/policy/api/kafka"
"github.com/sirupsen/logrus"
"golang.org/x/sys/unix"
"google.golang.org/protobuf/proto"

"github.com/cilium/cilium/pkg/flowdebug"
"github.com/cilium/cilium/pkg/identity"
"github.com/cilium/cilium/pkg/option"
kafka_api "github.com/cilium/cilium/pkg/policy/api/kafka"
"github.com/cilium/cilium/pkg/proxy/accesslog"
"github.com/cilium/cilium/pkg/proxy/logger"
)
Expand Down
2 changes: 1 addition & 1 deletion pkg/envoy/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
envoy_config_tcp "github.com/cilium/proxy/go/envoy/extensions/filters/network/tcp_proxy/v3"
envoy_config_tls "github.com/cilium/proxy/go/envoy/extensions/transport_sockets/tls/v3"
envoy_type_matcher "github.com/cilium/proxy/go/envoy/type/matcher/v3"
"github.com/cilium/proxy/pkg/policy/api/kafka"
"github.com/sirupsen/logrus"
"golang.org/x/sys/unix"
"google.golang.org/protobuf/proto"
Expand All @@ -44,7 +45,6 @@ import (
"github.com/cilium/cilium/pkg/option"
"github.com/cilium/cilium/pkg/policy"
"github.com/cilium/cilium/pkg/policy/api"
"github.com/cilium/cilium/pkg/policy/api/kafka"
"github.com/cilium/cilium/pkg/proxy/endpoint"
"github.com/cilium/cilium/pkg/u8proto"
)
Expand Down
2 changes: 1 addition & 1 deletion pkg/envoy/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ import (
envoy_config_listener "github.com/cilium/proxy/go/envoy/config/listener/v3"
envoy_config_route "github.com/cilium/proxy/go/envoy/config/route/v3"
envoy_type_matcher "github.com/cilium/proxy/go/envoy/type/matcher/v3"
"github.com/cilium/proxy/pkg/policy/api/kafka"

"github.com/cilium/cilium/pkg/checker"
"github.com/cilium/cilium/pkg/identity"
"github.com/cilium/cilium/pkg/identity/cache"
"github.com/cilium/cilium/pkg/labels"
"github.com/cilium/cilium/pkg/policy"
"github.com/cilium/cilium/pkg/policy/api"
"github.com/cilium/cilium/pkg/policy/api/kafka"
"github.com/cilium/cilium/pkg/proxy/endpoint"
"github.com/cilium/cilium/pkg/proxy/endpoint/test"
testidentity "github.com/cilium/cilium/pkg/testutils/identity"
Expand Down
3 changes: 2 additions & 1 deletion pkg/kafka/policy.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ package kafka
import (
"github.com/sirupsen/logrus"

api "github.com/cilium/proxy/pkg/policy/api/kafka"

"github.com/cilium/cilium/pkg/flowdebug"
api "github.com/cilium/cilium/pkg/policy/api/kafka"
)

type Rule struct {
Expand Down
2 changes: 1 addition & 1 deletion pkg/kafka/policy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
. "github.com/cilium/checkmate"
"github.com/cilium/kafka/proto"

"github.com/cilium/cilium/pkg/policy/api/kafka"
"github.com/cilium/proxy/pkg/policy/api/kafka"
)

// Hook up gocheck into the "go test" runner.
Expand Down
2 changes: 1 addition & 1 deletion pkg/policy/api/l4.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
package api

import (
"github.com/cilium/cilium/pkg/policy/api/kafka"
"github.com/cilium/proxy/pkg/policy/api/kafka"
)

// L4Proto is a layer 4 protocol name
Expand Down
2 changes: 1 addition & 1 deletion pkg/policy/api/rule_validation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ import (
"fmt"

. "github.com/cilium/checkmate"
"github.com/cilium/proxy/pkg/policy/api/kafka"

slim_metav1 "github.com/cilium/cilium/pkg/k8s/slim/k8s/apis/meta/v1"
"github.com/cilium/cilium/pkg/labels"
"github.com/cilium/cilium/pkg/option"
"github.com/cilium/cilium/pkg/policy/api/kafka"
)

// This test ensures that only PortRules which have L7Rules associated with them
Expand Down
2 changes: 1 addition & 1 deletion pkg/policy/api/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ import (
"testing"

. "github.com/cilium/checkmate"
"github.com/cilium/proxy/pkg/policy/api/kafka"

"github.com/cilium/cilium/pkg/defaults"
"github.com/cilium/cilium/pkg/fqdn/re"
"github.com/cilium/cilium/pkg/policy/api/kafka"
)

// Hook up gocheck into the "go test" runner.
Expand Down