Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: Fix default API server addr in metrics subcommand #26132

Merged

Commits on Jun 12, 2023

  1. operator: Fix default API server addr in metrics subcommand

    The operator API server has been modularized into its independent cell
    in a previous commit.
    
    Doing that, the flag to specify a custom address for the server has been
    moved from the global operator config to the new cell config.
    
    The `metrics list` subcommand needs to know the operator API server
    address to query the "/metrics" endpoint.  Before the modularization,
    the subcommand was at least able to query the server if that was started
    at the default address.
    
    This commit adds a new flag to specify the address of the operator API
    server. Also, the default value for this flag is set to the same default
    used in the operator/api server cell.  Doing that fixes the bug
    introduced in the modularization and also allows to specify another
    address if the operator API server is listening on a non-default one.
    
    Fixes: 11d5856 ("operator/api: Modularize api server")
    
    Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
    pippolo84 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    113d8bf View commit details
    Browse the repository at this point in the history