bgpv1: Avoid ports from common ip_local_port_range in unit tests #26174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rastislavs
added
area/CI
rastislavs
commented
Jun 13, 2023
rastislavs
force-pushed
the
fix-bgp-port-flake
branch
3 times, most recently
from
3d401b5
to
9558912
Compare
|
/test |
Unit tests should not use ports from the common Linux ip_local_port_range (32768-60999), as those ports may be already used as a source port for an outgoing connection. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
rastislavs
force-pushed
the
fix-bgp-port-flake
branch
from
9558912
to
da7a280
Compare
harsimran-pabla
approved these changes
Jun 14, 2023
|
/test (rebased to fetch latest CI changes/fixes) |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests should not use ports from the common default Linux
ip_local_port_range(32768-60999), as those ports may be already used as a source port for an outgoing connection. This can cause intermittent failures in the CI manifesting asbind: address already in use.E.g. in my Linux system:
This should avoid the CI issues for now, but the tests should be refactored - filed a follow-up issue in #26209
Fixes: #24691